Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: extra env variables for Hydra & Kratos cronjobs #632

Merged

Conversation

David-Wobrock
Copy link
Contributor

@David-Wobrock David-Wobrock commented Aug 14, 2023

Related Issue or Design Document

In order for the cronjobs to send traces about their execution, they require as environment variables the correct host.
But we cannot pass them today.

Checklist

  • I have read the contributing guidelines and signed the CLA.
  • I have referenced an issue containing the design document if my change introduces a new feature.
  • I have read the security policy.
  • I confirm that this pull request does not address a security vulnerability.
    If this pull request addresses a security vulnerability,
    I confirm that I got approval (please contact security@ory.sh) from the maintainers to push the changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added the necessary documentation within the code base (if appropriate).

Further comments

@David-Wobrock David-Wobrock marked this pull request as ready for review August 14, 2023 11:18
Copy link
Collaborator

@Demonsthere Demonsthere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please run make helm-docs to regen the readme file :)

helm/charts/hydra/templates/janitor-cron-job.yaml Outdated Show resolved Hide resolved
helm/charts/kratos/templates/cleanup-cron-job.yaml Outdated Show resolved Hide resolved
@David-Wobrock David-Wobrock force-pushed the feat/env-variables-hydra-kratos-cronjobs branch from d7adbf6 to 0d5e73f Compare August 14, 2023 11:50
@David-Wobrock
Copy link
Contributor Author

Thanks for the review @Demonsthere 🙏
I pushed some edits.

Copy link
Collaborator

@Demonsthere Demonsthere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Completely valid use case, we can merge now :)

@Demonsthere Demonsthere merged commit bc90c81 into ory:master Aug 14, 2023
14 checks passed
@David-Wobrock David-Wobrock deleted the feat/env-variables-hydra-kratos-cronjobs branch August 14, 2023 12:23
@David-Wobrock
Copy link
Contributor Author

Thanks!
Looking forward the next release of the charts 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants