feat: added priorityClassName to all charts #638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Demonsthere
requested changes
Sep 7, 2023
helm/charts/kratos/values.yaml
Outdated
| @@ -425,6 +429,10 @@ statefulSet: | |||
| # lines, adjust them as necessary, and remove the curly braces after 'labels:'. | |||
| # e.g. type: app | |||
|
|
|||
| # -- Pod priority | |||
| # https://kubernetes.io/docs/concepts/configuration/pod-priority-preemption/ | |||
| # priorityClassName: "" | |||
There was a problem hiding this comment.
Suggested change
| # priorityClassName: "" | |
| priorityClassName: "" |
There was a problem hiding this comment.
empty string is evaluated to false in both if and with clauses, so we can safely use it as a default value :)
| @@ -202,6 +202,9 @@ spec: | |||
| {{- with $extraVolumes }} | |||
| {{- toYaml . | nindent 8 }} | |||
| {{- end }} | |||
| {{- if .Values.priorityClassName }} | |||
There was a problem hiding this comment.
For internal consistency please use the with method instead of if :)
| @@ -29,6 +29,10 @@ sidecar: | |||
| tag: v0.1.2 | |||
| envs: {} | |||
|
|
|||
| # -- Pod priority | |||
| # https://kubernetes.io/docs/concepts/configuration/pod-priority-preemption/ | |||
| priorityClassName: "" | |||
There was a problem hiding this comment.
also please update the values.yaml files in the hack/values directory to set those fields. This allows the CI to verify if they generate valid manifest files
Signed-off-by: Mathias Maes <mathias.maes@aloxy.io>
WatcherWhale
force-pushed
the
priorityClasses
branch
from
f835526
to
ec176c5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment, only the hydra and hydra-maester charts allow configuring the priorityClassName. This pull request introduces this configuration option to the other charts as well.
Checklist
If this pull request addresses a security vulnerability,
I confirm that I got approval (please contact security@ory.sh) from the maintainers to push the changes.