chore: format and linter settings (#274)

.golangci.yml

@@ -1,7 +1,12 @@
 linters:
   enable-all: false
-  disable-all: true
   enable:
     - gosec
-    - vet
     - goimports
+  disable:
+    - vet
+    - structcheck
+
+linters-settings:
+  goimports:
+    local-prefixes: github.com/ory/keto

cmd/client/grpc_client.go

@@ -2,10 +2,11 @@ package client
 
 import (
 	"context"
+	"time"
+
 	"github.com/spf13/cobra"
 	"github.com/spf13/pflag"
 	"google.golang.org/grpc"
-	"time"
 )
 
 const (
@@ -17,7 +18,8 @@ func GetGRPCConn(cmd *cobra.Command) (*grpc.ClientConn, error) {
 	if err != nil {
 		return nil, err
 	}
-	ctx, _ := context.WithTimeout(context.Background(), 3*time.Second)
+	ctx, cancel := context.WithTimeout(context.Background(), 3*time.Second)
+	defer cancel()
 	return grpc.DialContext(ctx, remote, grpc.WithInsecure(), grpc.WithBlock())
 }
 

cmd/relation/get.go

@@ -3,9 +3,11 @@ package relation
 import (
 	"context"
 	"fmt"
+
+	"github.com/spf13/cobra"
+
 	"github.com/ory/keto/cmd/client"
 	"github.com/ory/keto/models"
-	"github.com/spf13/cobra"
 )
 
 var getByUserRelationCmd = &cobra.Command{

cmd/relation/root.go

@@ -1,8 +1,9 @@
 package relation
 
 import (
-	"github.com/ory/keto/cmd/client"
 	"github.com/spf13/cobra"
+
+	"github.com/ory/keto/cmd/client"
 )
 
 var relationCmd = &cobra.Command{

cmd/root.go

@@ -16,12 +16,13 @@ package cmd
 
 import (
 	"fmt"
-	"github.com/ory/keto/cmd/relation"
 	"os"
 	"path/filepath"
 	"runtime"
 	"strings"
 
+	"github.com/ory/keto/cmd/relation"
+
 	"github.com/spf13/cobra"
 
 	"github.com/ory/viper"

cmd/serve.go

@@ -16,17 +16,19 @@ package cmd
 
 import (
 	"fmt"
+	"net"
+	"net/http"
+	"os"
+	"sync"
+
 	"github.com/julienschmidt/httprouter"
 	"github.com/ory/graceful"
+	"github.com/spf13/cobra"
+	"google.golang.org/grpc"
+
 	"github.com/ory/keto/driver"
 	"github.com/ory/keto/models"
 	"github.com/ory/keto/relation"
-	"github.com/spf13/cobra"
-	"google.golang.org/grpc"
-	"net"
-	"net/http"
-	"os"
-	"sync"
 
 	"github.com/ory/x/viperx"
 
@@ -46,6 +48,7 @@ on configuration options, open the configuration documentation:
 
 >> https://github.com/ory/keto/blob/` + Version + `/docs/config.yaml <<`,
 	Run: func(cmd *cobra.Command, args []string) {
+		/* #nosec G102 - TODO this will be configurable */
 		lis, err := net.Listen("tcp", ":4467")
 		if err != nil {
 			fmt.Fprintf(cmd.ErrOrStderr(), "%+v\n", err)

cmd/server/serve.go

@@ -115,7 +115,7 @@ func RunServe(
 		} else {
 			server.TLSConfig = &tls.Config{
 				Certificates: cert,
-				MinVersion:   tls.VersionTLS10,
+				MinVersion:   tls.VersionTLS13,
 			}
 		}
 

doc_swagger.go

@@ -17,6 +17,7 @@ package main
 // The standard error format
 //
 // swagger:response genericError
+// nolint:deadcode,unused
 type genericError struct {
 	// in: body
 	Body struct {
@@ -37,4 +38,5 @@ type genericError struct {
 // An empty response
 //
 // swagger:response emptyResponse
+// nolint:deadcode,unused
 type emptyResponse struct{}

driver/driver_default.go

@@ -1,8 +1,9 @@
 package driver
 
 import (
-	"github.com/ory/keto/driver/configuration"
 	"github.com/ory/x/logrusx"
+
+	"github.com/ory/keto/driver/configuration"
 )
 
 type DefaultDriver struct {

driver/registry_default.go

@@ -2,10 +2,11 @@ package driver
 
 import (
 	"github.com/ory/herodot"
+	"github.com/ory/x/logrusx"
+
 	"github.com/ory/keto/persistence/memory"
 	"github.com/ory/keto/relation"
 	"github.com/ory/keto/x"
-	"github.com/ory/x/logrusx"
 )
 
 var _ relation.ManagerProvider = &RegistryDefault{}

persistence/memory/definitions.go

@@ -1,9 +1,10 @@
 package memory
 
 import (
+	"sync"
+
 	"github.com/ory/keto/models"
 	"github.com/ory/keto/relation"
-	"sync"
 )
 
 type Persister struct {

persistence/memory/relations.go

@@ -2,6 +2,7 @@ package memory
 
 import (
 	"context"
+
 	"github.com/ory/keto/models"
 )
 

relation/definitions.go

@@ -2,6 +2,7 @@ package relation
 
 import (
 	"context"
+
 	"github.com/ory/keto/models"
 )
 

relation/grpc_server.go

@@ -2,6 +2,7 @@ package relation
 
 import (
 	"context"
+
 	"github.com/ory/keto/models"
 )
 

relation/handler.go

@@ -1,12 +1,14 @@
 package relation
 
 import (
+	"net/http"
+
 	"github.com/julienschmidt/httprouter"
 	"github.com/ory/herodot"
+	"github.com/pkg/errors"
+
 	"github.com/ory/keto/models"
 	"github.com/ory/keto/x"
-	"github.com/pkg/errors"
-	"net/http"
 )
 
 type (