Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: adjust details missed for v0.7 #762

Merged
merged 1 commit into from
Oct 8, 2021
Merged

docs: adjust details missed for v0.7 #762

merged 1 commit into from
Oct 8, 2021

Conversation

zepatrik
Copy link
Member

@zepatrik zepatrik commented Oct 8, 2021

No description provided.

@@ -40,15 +40,6 @@ will evaluate to false (a.k.a. rejected).
Vice versa, all relation tuples containing an object have to be in the same
namespace to reference the same object.

## Migrations
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not apply anymore.

Comment on lines +49 to +51
5. Run `keto migrate up --yes` considering the points raised in
[preparations](#preparations). This command will apply SQL schema changes,
but not yet migrate data.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added this step.

Comment on lines +63 to +70
## Options for Adjusting the Migration Process

The `keto namespace migrate legacy` command supports multiple options:

- interactive mode with manual approval by not specifying `--yes`
- migrate single namespace by specifying its name as an argument
- only delete old tables by specifying `--down-only`; useful if you did not
approve the down migration previously
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The migrate command does actually already delete the old tables after a successful migration. These options were added to make it clear how the process can be adjusted. FYI @piotrmsc

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome, thx for checking that @zepatrik :)

@zepatrik zepatrik merged commit caa18c0 into master Oct 8, 2021
@zepatrik zepatrik deleted the docs/v0.7-updates branch October 8, 2021 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants