docs: adjust details missed for v0.7 #762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zepatrik
commented
Oct 8, 2021
| @@ -40,15 +40,6 @@ will evaluate to false (a.k.a. rejected). | |||
| Vice versa, all relation tuples containing an object have to be in the same | |||
| namespace to reference the same object. | |||
|
|
|||
| ## Migrations | |||
There was a problem hiding this comment.
This does not apply anymore.
Comment on lines
+49
to
+51
| 5. Run `keto migrate up --yes` considering the points raised in | ||
| [preparations](#preparations). This command will apply SQL schema changes, | ||
| but not yet migrate data. |
Comment on lines
+63
to
+70
| ## Options for Adjusting the Migration Process | ||
|
|
||
| The `keto namespace migrate legacy` command supports multiple options: | ||
|
|
||
| - interactive mode with manual approval by not specifying `--yes` | ||
| - migrate single namespace by specifying its name as an argument | ||
| - only delete old tables by specifying `--down-only`; useful if you did not | ||
| approve the down migration previously |
There was a problem hiding this comment.
The migrate command does actually already delete the old tables after a successful migration. These options were added to make it clear how the process can be adjusted. FYI @piotrmsc
There was a problem hiding this comment.
awesome, thx for checking that @zepatrik :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.