chore: add missing ON DELETE CASCADE to keto_relation_tuples
#1264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonas-jonas
commented
Feb 28, 2023
| ALTER TABLE | ||
| keto_relation_tuples DROP CONSTRAINT keto_relation_tuples_uuid_nid_fk, | ||
| ADD | ||
| CONSTRAINT keto_relation_tuples_nid_fk FOREIGN KEY (nid) REFERENCES networks (id) ON UPDATE RESTRICT ON DELETE CASCADE; |
There was a problem hiding this comment.
CockroachDB does not seem to like dropping constraints and re-creating them with the same name in the same transaction. So I renamed the constraint keto_relation_tuples_nid_fk, as it matches the table name better anyway.
jonas-jonas
commented
Feb 28, 2023
| @@ -0,0 +1,109 @@ | |||
| ALTER TABLE | |||
There was a problem hiding this comment.
SQLite does not allow altering constraints...
jonas-jonas
force-pushed
the
jonas-jonas/fix/addMissinOnDelete
branch
3 times, most recently
from
2d52580
to
3c0d790
Compare
jonas-jonas
force-pushed
the
jonas-jonas/fix/addMissinOnDelete
branch
from
3c0d790
to
922c7c4
Compare
zepatrik
approved these changes
Feb 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue(s)
Checklist
introduces a new feature.
contributing code guidelines.
vulnerability. If this pull request addresses a security vulnerability, I
confirm that I got the approval (please contact
security@ory.sh) from the maintainers to push
the changes.
works.
Further Comments