Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: rewrite and traversal #1531

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

test: rewrite and traversal #1531

wants to merge 2 commits into from

Conversation

rbnbr
Copy link

@rbnbr rbnbr commented Jun 4, 2024

Related issue(s)

#1529 comment

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    security@ory.sh) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

I added a test similar to #1529 though for some reason I cannot run the test command on my machine at all, e.g., go test -tags sqlite .\internal\check\ fails for the current master branch.

@CLAassistant
Copy link

CLAassistant commented Jun 4, 2024

CLA assistant check
All committers have signed the CLA.

@aeneasr
Copy link
Member

aeneasr commented Jul 4, 2024

Can this be merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants