fix: add description attribute to access control policy role #215
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue
This PR fixes issue #213.
Proposed changes
As discussed with @aeneasr, the fix just adds the
description
attribute to theRole
struct. Existing tests have been updated to include the new attribute, as well as the API documentation.Checklist
vulnerability. If this pull request addresses a security. vulnerability, I
confirm that I got green light (please contact
security@ory.sh) from the maintainers to push
the changes.
works.
Further comments
Running the tests with
$ go test ./...
(as described in the contributing guidelines) had some issues, which I don't know how to resolve. However, the issues seems to have no relation to my changes. These are the output of relevance from the above command:The tests were run in a Cygwin64 terminal on Windows, and the host had Docker installed.