test: add command tests #487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aeneasr
reviewed
Mar 15, 2021
| @@ -130,6 +134,10 @@ func (t *Tree) ToProto() *acl.SubjectTree { | |||
|
|
|||
| // swagger:ignore | |||
| func TreeFromProto(t *acl.SubjectTree) (*Tree, error) { | |||
| if t == nil { | |||
| return nil, nil | |||
There was a problem hiding this comment.
Is passing a nil value here not an error?
There was a problem hiding this comment.
That depends on whether the expand engine should never return nil. Currently there are two cases:
But that can be fixed, although I don't think they are an error.
There was a problem hiding this comment.
Ok, as long as the code is able to deal with nil trees downstream I think this is fine. Is that tested?
There was a problem hiding this comment.
Not too much (that's why I found it right now), I will add some more tests.
Locally, this resulted in flaky tests as up and down migrations where applied racy.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue
multiple comments from the review
Proposed changes