Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update to latest x and json schema #817

Merged
merged 2 commits into from
Jan 21, 2022
Merged

chore: update to latest x and json schema #817

merged 2 commits into from
Jan 21, 2022

Conversation

aeneasr
Copy link
Member

@aeneasr aeneasr commented Jan 21, 2022

Related issue(s)

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security. vulnerability, I
    confirm that I got green light (please contact
    security@ory.sh) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

@aeneasr
Copy link
Member Author

aeneasr commented Jan 21, 2022

@zepatrik tests fail locally with:


foobar@Aeneass-MBP keto % go test -tags sqlite -short ./...
# github.com/ory/keto/internal/e2e [github.com/ory/keto/internal/e2e.test]
internal/e2e/sdk_client_test.go:56:3: cannot use &r.Namespace (type *string) as type string in field value
internal/e2e/sdk_client_test.go:79:12: undefined: write.NewDeleteRelationTupleParamsWithTimeout
internal/e2e/sdk_client_test.go:93:36: c.getWriteClient().Write.DeleteRelationTuple undefined (type write.ClientService has no field or method DeleteRelationTuple)
internal/e2e/sdk_client_test.go:98:12: undefined: write.NewDeleteRelationTupleParamsWithTimeout
internal/e2e/sdk_client_test.go:115:36: c.getWriteClient().Write.DeleteRelationTuple undefined (type write.ClientService has no field or method DeleteRelationTuple)

This is on master also

@aeneasr aeneasr merged commit 8381bf2 into master Jan 21, 2022
@aeneasr aeneasr deleted the bump-schema branch January 21, 2022 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants