Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: users should return to previous screen on mfa required #262

Merged
merged 2 commits into from
Jun 19, 2023

Conversation

Benehiko
Copy link
Contributor

This PR adds the current requested page as the return_to page when redirecting to login with aal=aal2.

This is especially true for when we want to redirect back to the original page the user was navigating to. This fixes the problem where a user has logged in and navigates directly to the settings page but still needs to complete MFA.
After completing the login flow the user is now stuck on the /welcome page.

Related Issue or Design Document

Checklist

  • I have read the contributing guidelines and signed the CLA.
  • I have referenced an issue containing the design document if my change introduces a new feature.
  • I have read the security policy.
  • I confirm that this pull request does not address a security vulnerability.
    If this pull request addresses a security vulnerability,
    I confirm that I got approval (please contact security@ory.sh) from the maintainers to push the changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added the necessary documentation within the code base (if appropriate).

Further comments

@aeneasr aeneasr merged commit 9b09cdf into master Jun 19, 2023
8 checks passed
@aeneasr aeneasr deleted the feat-previous-screen branch June 19, 2023 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants