Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add support for native apple authentication #78

Merged
merged 3 commits into from
Oct 19, 2023
Merged

feat: add support for native apple authentication #78

merged 3 commits into from
Oct 19, 2023

Conversation

jonas-jonas
Copy link
Contributor

Related Issue or Design Document

Checklist

  • I have read the contributing guidelines and signed the CLA.
  • I have referenced an issue containing the design document if my change introduces a new feature.
  • I have read the security policy.
  • I confirm that this pull request does not address a security vulnerability.
    If this pull request addresses a security vulnerability,
    I confirm that I got approval (please contact security@ory.sh) from the maintainers to push the changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added the necessary documentation within the code base (if appropriate).

Further comments

@jonas-jonas jonas-jonas self-assigned this Sep 7, 2023
@jonas-jonas jonas-jonas marked this pull request as ready for review September 12, 2023 12:50
Benehiko
Benehiko approved these changes Sep 25, 2023
View reviewed changes
Copy link
Contributor

@Benehiko Benehiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jonas-jonas jonas-jonas merged commit df56e2b into master Oct 19, 2023
4 checks passed
@jonas-jonas jonas-jonas deleted the jonas-jonas/appleAuth branch October 19, 2023 15:46
jonas-jonas added a commit that referenced this pull request Oct 23, 2023
@jonas-jonas
chore: revert "feat: add support for native apple authentication (#78)"
0117f35 
This reverts commit df56e2b.
Benehiko pushed a commit that referenced this pull request Oct 23, 2023
@jonas-jonas
chore: revert "feat: add support for native apple authentication (#78)…
b004a84 
…" (#82)

This reverts commit df56e2b.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Benehiko Benehiko Benehiko approved these changes

@aeneasr aeneasr Awaiting requested review from aeneasr

Assignees

@jonas-jonas jonas-jonas

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jonas-jonas @Benehiko