fix: remove initial_value again as it was not useful outside of booleans

ory · Oct 19, 2021 · 0cc984b · 0cc984b
1 parent 287269c
commit 0cc984b
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 23 deletions.
diff --git a/selfservice/strategy/lookup/nodes.go b/selfservice/strategy/lookup/nodes.go
@@ -6,31 +6,22 @@ import (
 )
 
 func NewRevealLookupNode() *node.Node {
-	return node.NewInputField(node.LookupReveal, "true", node.LookupGroup, node.InputAttributeTypeSubmit,
-		node.WithInputAttributes(func(a *node.InputAttributes) {
-			a.InitialValue = "false"
-		})).
+	return node.NewInputField(node.LookupReveal, "true", node.LookupGroup, node.InputAttributeTypeSubmit).
 		WithMetaLabel(text.NewInfoSelfServiceSettingsRevealLookup())
 }
 
 func NewRegenerateLookupNode() *node.Node {
 	return node.NewInputField(
-		node.LookupRegenerate, "true", node.LookupGroup, node.InputAttributeTypeSubmit, node.WithInputAttributes(func(a *node.InputAttributes) {
-			a.InitialValue = "false"
-		})).
+		node.LookupRegenerate, "true", node.LookupGroup, node.InputAttributeTypeSubmit).
 		WithMetaLabel(text.NewInfoSelfServiceSettingsRegenerateLookup())
 }
 
 func NewDisableLookupNode() *node.Node {
-	return node.NewInputField(node.LookupDisable, "true", node.LookupGroup, node.InputAttributeTypeSubmit, node.WithInputAttributes(func(a *node.InputAttributes) {
-		a.InitialValue = "false"
-	})).
+	return node.NewInputField(node.LookupDisable, "true", node.LookupGroup, node.InputAttributeTypeSubmit).
 		WithMetaLabel(text.NewInfoSelfServiceSettingsDisableLookup())
 }
 
 func NewConfirmLookupNode() *node.Node {
-	return node.NewInputField(node.LookupConfirm, "true", node.LookupGroup, node.InputAttributeTypeSubmit, node.WithInputAttributes(func(a *node.InputAttributes) {
-		a.InitialValue = "false"
-	})).
+	return node.NewInputField(node.LookupConfirm, "true", node.LookupGroup, node.InputAttributeTypeSubmit).
 		WithMetaLabel(text.NewInfoSelfServiceSettingsLookupConfirm())
 }
diff --git a/ui/node/attributes.go b/ui/node/attributes.go
@@ -56,12 +56,6 @@ type InputAttributes struct {
 	// The input's value.
 	FieldValue interface{} `json:"value,omitempty" faker:"string"`
 
-	// The input's initial value. This is primarily used for fields
-	// which are e.g. checkboxes or buttons (active/inactive).
-	// If this field is set on a button, it implies that
-	// clicking the button should trigger the "value" to be set.
-	InitialValue interface{} `json:"initial_value,omitempty" faker:"string"`
-
 	// Mark this input field as required.
 	Required bool `json:"required,omitempty"`
 

diff --git a/ui/node/attributes_input.go b/ui/node/attributes_input.go
@@ -180,10 +180,6 @@ func NewInputFieldFromSchema(name string, group Group, p jsonschemax.Path, opts
 		meta.Label = text.NewInfoNodeLabelGenerated(p.Title)
 	}
 
-	if attr.Type == InputAttributeTypeCheckbox {
-		attr.InitialValue = false
-	}
-
 	return &Node{
 		Type:       Input,
 		Attributes: applyInputAttributes(opts, attr),