fix: don't treat missing session as error in tracing

ory · Feb 7, 2023 · 290d28a · 290d28a
1 parent a7f9414
commit 290d28a
Showing 1 changed file with 7 additions and 1 deletion.
diff --git a/session/manager_http.go b/session/manager_http.go
@@ -195,7 +195,13 @@ func (s *ManagerHTTP) extractToken(r *http.Request) string {
 
 func (s *ManagerHTTP) FetchFromRequest(ctx context.Context, r *http.Request) (_ *Session, err error) {
 	ctx, span := s.r.Tracer(ctx).Tracer().Start(ctx, "sessions.ManagerHTTP.FetchFromRequest")
-	defer otelx.End(span, &err)
+	defer func() {
+		if e := new(ErrNoActiveSessionFound); errors.As(err, &e) {
+			span.End()
+		} else {
+			otelx.End(span, &err)
+		}
+	}()
 
 	token := s.extractToken(r)
 	if token == "" {