chore: reenable and fix schema tests (#737)

.schema/config.schema.json

@@ -147,7 +147,32 @@
         "client_id",
         "client_secret",
         "mapper_url"
-      ]
+      ],
+      "if": {
+        "properties": {
+          "provider": {
+            "const": "microsoft"
+          }
+        },
+        "required": [
+          "provider"
+        ]
+      },
+      "then": {
+        "required": [
+          "tenant"
+        ]
+      },
+      "else": {
+        "not": {
+          "properties": {
+            "tenant": {}
+          },
+          "required": [
+            "tenant"
+          ]
+        }
+      }
     },
     "selfServiceAfterSettingsMethod": {
       "type": "object",
@@ -895,12 +920,15 @@
                 ]
               }
             },
+            "required": [
+              "id",
+              "url"
+            ],
             "not": {
               "type": "object",
               "properties": {
                 "id": {
-                  "type": "string",
-                  "pattern": "^default$"
+                  "const": "default"
                 }
               },
               "additionalProperties": true
@@ -1049,9 +1077,15 @@
                           "enabled": {
                             "const": true
                           }
-                        }
+                        },
+                        "required": [
+                          "enabled"
+                        ]
                       }
-                    }
+                    },
+                    "required": [
+                      "verification"
+                    ]
                   },
                   {
                     "properties": {
@@ -1060,41 +1094,27 @@
                           "enabled": {
                             "const": true
                           }
-                        }
+                        },
+                        "required": [
+                          "enabled"
+                        ]
                       }
-                    }
+                    },
+                    "required": [
+                      "recovery"
+                    ]
                   }
                 ]
               }
-            }
+            },
+            "required": [
+              "flows"
+            ]
           }
-        }
-      },
-      "then": {
+        },
         "required": [
-          "courier"
+          "selfservice"
         ]
-      }
-    },
-    {
-      "if": {
-        "properties": {
-          "selfservice": {
-            "properties": {
-              "flows": {
-                "properties": {
-                  "verification": {
-                    "properties": {
-                      "enabled": {
-                        "const": true
-                      }
-                    }
-                  }
-                }
-              }
-            }
-          }
-        }
       },
       "then": {
         "required": [

test/schema/README.md

@@ -0,0 +1,17 @@
+# Schema Tests
+
+This test works by validating cases of the payload against a schema.
+To add a case, place a file in the `${schemaName}.schema.test.${success|failure}` folder.
+A success case should validate, a failure case should throw a validation error.
+
+## Handling of "$ref"
+
+To allow testing definitions on their own, and reduce the size of individual cases,
+every `"$ref"` in the schema will be replaced with `"const"` before validation.
+This means that a case only has to define the pointer as a string. Example:
+
+```yaml
+default_browser_return_url: "#/definitions/defaultReturnTo"
+hooks:
+  - "#/definitions/selfServiceSessionRevokerHook"
+```

test/schema/fixtures/config.schema.test.failure/root.defaultSchemaNotAllowed.yml

@@ -0,0 +1,10 @@
+selfservice:
+  default_browser_return_url: "#/definitions/defaultReturnTo"
+
+dsn: foo
+
+identity:
+  default_schema_url: https://example.com
+  schemas:
+    - id: default
+      url: file://path/to/identity.traits.schema.json

test/schema/fixtures/config.schema.test.failure/root.requiresCourierRecovery.yml

@@ -0,0 +1,10 @@
+selfservice:
+  default_browser_return_url: "#/definitions/defaultReturnTo"
+  flows:
+    recovery:
+      enabled: true
+
+dsn: foo
+
+identity:
+  default_schema_url: https://example.com

test/schema/fixtures/config.schema.test.failure/root.requiresCourierVerification.yml

@@ -0,0 +1,10 @@
+selfservice:
+  default_browser_return_url: "#/definitions/defaultReturnTo"
+  flows:
+    verification:
+      enabled: true
+
+dsn: foo
+
+identity:
+  default_schema_url: https://example.com

test/schema/fixtures/config.schema.test.failure/selfServiceOIDCProvider.invalidTypes.yaml

@@ -0,0 +1,11 @@
+id: 1
+provider: unknown
+client_id: 1
+client_secret: 1
+issuer_url: not an URL
+auth_url: not an URL
+token_url: not an URL
+mapper_url: not an URL
+scope:
+  - 1
+tenant: 1

test/schema/fixtures/config.schema.test.failure/selfServiceOIDCProvider.tenantNotWithGithub.yaml

@@ -0,0 +1,6 @@
+id: foo
+provider: github
+client_id: asdf
+client_secret: asdf
+mapper_url: file://./mapper_file
+tenant: org

test/schema/fixtures/config.schema.test.failure/selfServiceOIDCProvider.tenantRequiredWithMicrosoft.yaml

@@ -0,0 +1,5 @@
+id: foo
+provider: microsoft
+client_id: asdf
+client_secret: asdf
+mapper_url: file://./mapper_file

test/schema/fixtures/config.schema.test.failure/version.invalid.yaml

@@ -0,0 +1 @@
+x1.0.0

test/schema/fixtures/config.schema.test.success/defaultReturnTo.URI-Reference.yaml

@@ -0,0 +1 @@
+/dashboard

test/schema/fixtures/config.schema.test.success/defaultReturnTo.URL.yaml

@@ -0,0 +1 @@
+https://my-app.com/dashboard