fix: use params per_page and page for pagination

.schema/api.swagger.json

@@ -94,8 +94,8 @@
             "type": "integer",
             "format": "int64",
             "default": 100,
-            "description": "Pagination Limit\n\nThis is the number of items per page.",
-            "name": "limit",
+            "description": "Items per Page\n\nThis is the number of items per page.",
+            "name": "per_page",
             "in": "query"
           },
           {

identity/handler.go

@@ -71,7 +71,7 @@ type identitiesListResponse struct {
 
 // swagger:parameters listIdentities
 type listIdentityParameters struct {
-	// Pagination Limit
+	// Items per Page
 	//
 	// This is the number of items per page.
 	//
@@ -80,7 +80,7 @@ type listIdentityParameters struct {
 	// default: 100
 	// min: 1
 	// max: 500
-	Limit int `json:"limit"`
+	ItemsPerPage int `json:"per_page"`
 
 	// Pagination Page
 	//
@@ -108,13 +108,20 @@ type listIdentityParameters struct {
 //       200: identityList
 //       500: genericError
 func (h *Handler) list(w http.ResponseWriter, r *http.Request, _ httprouter.Params) {
-	page, limit := x.ParsePagination(r)
-	is, err := h.r.IdentityPool().ListIdentities(r.Context(), page, limit)
+	page, itemsPerPage := x.ParsePagination(r)
+	is, err := h.r.IdentityPool().ListIdentities(r.Context(), page, itemsPerPage)
 	if err != nil {
 		h.r.Writer().WriteError(w, r, err)
 		return
 	}
 
+	total, err := h.r.IdentityPool().CountIdentities(r.Context())
+	if err != nil {
+		h.r.Writer().WriteError(w, r, err)
+		return
+	}
+
+	x.PaginationHeader(w, urlx.AppendPaths(h.c.SelfAdminURL(), IdentitiesPath), total, page, itemsPerPage)
 	h.r.Writer().Write(w, r, is)
 }
 

identity/handler_test.go

@@ -10,6 +10,7 @@ import (
 
 	"github.com/ory/x/urlx"
 
+	"github.com/ory/kratos/internal/httpclient/client"
 	"github.com/ory/kratos/internal/testhelpers"
 	"github.com/ory/kratos/schema"
 

identity/pool.go

@@ -30,7 +30,11 @@ import (
 
 type (
 	Pool interface {
-		ListIdentities(ctx context.Context, page, limit int) ([]Identity, error)
+		// ListIdentities lists all identities in the store given the page and itemsPerPage.
+		ListIdentities(ctx context.Context, page, itemsPerPage int) ([]Identity, error)
+
+		// CountIdentities counts the number of identities in the store.
+		CountIdentities(ctx context.Context) (int64, error)
 
 		// GetIdentity returns an identity by its id. Will return an error if the identity does not exist or backend
 		// connectivity is broken.
@@ -142,6 +146,10 @@ func TestPool(p PrivilegedPool) func(t *testing.T) {
 			require.NoError(t, p.CreateIdentity(context.Background(), i))
 			assert.NotEqual(t, uuid.Nil, i.ID)
 			createdIDs = append(createdIDs, i.ID)
+
+			count, err := p.CountIdentities(context.Background())
+			require.NoError(t, err)
+			assert.EqualValues(t, 1, count)
 		})
 
 		t.Run("case=create with default values", func(t *testing.T) {
@@ -156,6 +164,10 @@ func TestPool(p PrivilegedPool) func(t *testing.T) {
 			assert.Equal(t, configuration.DefaultIdentityTraitsSchemaID, actual.SchemaID)
 			assert.Equal(t, defaultSchema.SchemaURL(exampleServerURL).String(), actual.SchemaURL)
 			assertEqual(t, expected, actual)
+
+			count, err := p.CountIdentities(context.Background())
+			require.NoError(t, err)
+			assert.EqualValues(t, 2, count)
 		})
 
 		t.Run("case=should error when the identity ID does not exist", func(t *testing.T) {

persistence/sql/persister_identity.go

@@ -157,6 +157,14 @@ func createRecoveryAddresses(ctx context.Context, tx *pop.Connection, i *identit
 	return nil
 }
 
+func (p *Persister) CountIdentities(ctx context.Context) (int64, error) {
+	count, err := p.c.WithContext(ctx).Count(new(identity.Identity))
+	if err != nil {
+		return 0, sqlcon.HandleError(err)
+	}
+	return int64(count), nil
+}
+
 func (p *Persister) CreateIdentity(ctx context.Context, i *identity.Identity) error {
 	if i.SchemaID == "" {
 		i.SchemaID = configuration.DefaultIdentityTraitsSchemaID