fix: add error checking when creating verification code (#3328)

persistence/sql/persister_verification.go

@@ -11,6 +11,7 @@ import (
 
 	"github.com/pkg/errors"
 
+	"github.com/ory/herodot"
 	"github.com/ory/kratos/identity"
 	"github.com/ory/kratos/persistence/sql/update"
 
@@ -257,12 +258,14 @@ func (p *Persister) CreateVerificationCode(ctx context.Context, c *code.CreateVe
 		NID:       p.NetworkID(ctx),
 	}
 
-	if c.VerifiableAddress != nil {
-		verificationCode.VerifiableAddress = c.VerifiableAddress
-		verificationCode.VerifiableAddressID = uuid.NullUUID{
-			UUID:  c.VerifiableAddress.ID,
-			Valid: true,
-		}
+	if c.VerifiableAddress == nil {
+		return nil, errors.WithStack(herodot.ErrNotFound.WithReason("can't create a verification code without a verifiable address"))
+	}
+
+	verificationCode.VerifiableAddress = c.VerifiableAddress
+	verificationCode.VerifiableAddressID = uuid.NullUUID{
+		UUID:  c.VerifiableAddress.ID,
+		Valid: true,
 	}
 
 	// This should not create the request eagerly because otherwise we might accidentally create an address that isn't

selfservice/strategy/code/verification_code.go

@@ -31,7 +31,7 @@ type VerificationCode struct {
 
 	// VerifiableAddress links this code to a verification address.
 	// required: true
-	VerifiableAddress *identity.VerifiableAddress `json:"verification_address" belongs_to:"identity_verifiable_addresses" fk_id:"VerificationAddVerifiableAddressIDressID"`
+	VerifiableAddress *identity.VerifiableAddress `json:"verification_address" belongs_to:"identity_verifiable_addresses"`
 
 	// ExpiresAt is the time (UTC) when the code expires.
 	// required: true
@@ -52,7 +52,7 @@ type VerificationCode struct {
 	NID    uuid.UUID `json:"-" faker:"-" db:"nid"`
 }
 
-func (VerificationCode) TableName(ctx context.Context) string {
+func (VerificationCode) TableName(context.Context) string {
 	return "identity_verification_codes"
 }