Skip to content

Commit

Permalink
fix: remove duplicate query in GetIdentity
Browse files Browse the repository at this point in the history
  • Loading branch information
@ory-bot
ory-bot committed Dec 27, 2022
1 parent 0b109cd commit cd625eb
Show file tree
Hide file tree
Showing 10 changed files with 36 additions and 44 deletions.
8 changes: 4 additions & 4 deletions persistence/sql/migratest/fixtures/settings_flow/194c5b05-0487-4a11-bcbc-f301c9ff9678.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -19,17 +19,17 @@
},
"verifiable_addresses": [
{
"id": "b2d59320-8564-4400-a39f-a22a497a23f1",
"value": "foobar+without-code@ory.sh",
"id": "c2427b6d-312b-46d9-9285-536db7ae11fd",
"value": "foobar@ory.sh",
"verified": false,
"via": "email",
"status": "pending",
"created_at": "2013-10-07T08:23:19Z",
"updated_at": "2013-10-07T08:23:19Z"
},
{
"id": "c2427b6d-312b-46d9-9285-536db7ae11fd",
"value": "foobar@ory.sh",
"id": "b2d59320-8564-4400-a39f-a22a497a23f1",
"value": "foobar+without-code@ory.sh",
"verified": false,
"via": "email",
"status": "pending",
Expand Down
8 changes: 4 additions & 4 deletions persistence/sql/migratest/fixtures/settings_flow/19ede218-928c-4e02-ab49-b76e12b34f31.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -20,17 +20,17 @@
},
"verifiable_addresses": [
{
"id": "b2d59320-8564-4400-a39f-a22a497a23f1",
"value": "foobar+without-code@ory.sh",
"id": "c2427b6d-312b-46d9-9285-536db7ae11fd",
"value": "foobar@ory.sh",
"verified": false,
"via": "email",
"status": "pending",
"created_at": "2013-10-07T08:23:19Z",
"updated_at": "2013-10-07T08:23:19Z"
},
{
"id": "c2427b6d-312b-46d9-9285-536db7ae11fd",
"value": "foobar@ory.sh",
"id": "b2d59320-8564-4400-a39f-a22a497a23f1",
"value": "foobar+without-code@ory.sh",
"verified": false,
"via": "email",
"status": "pending",
Expand Down
8 changes: 4 additions & 4 deletions persistence/sql/migratest/fixtures/settings_flow/21c5f714-3089-49d2-b387-f244d4dd9e00.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -20,17 +20,17 @@
},
"verifiable_addresses": [
{
"id": "b2d59320-8564-4400-a39f-a22a497a23f1",
"value": "foobar+without-code@ory.sh",
"id": "c2427b6d-312b-46d9-9285-536db7ae11fd",
"value": "foobar@ory.sh",
"verified": false,
"via": "email",
"status": "pending",
"created_at": "2013-10-07T08:23:19Z",
"updated_at": "2013-10-07T08:23:19Z"
},
{
"id": "c2427b6d-312b-46d9-9285-536db7ae11fd",
"value": "foobar@ory.sh",
"id": "b2d59320-8564-4400-a39f-a22a497a23f1",
"value": "foobar+without-code@ory.sh",
"verified": false,
"via": "email",
"status": "pending",
Expand Down
8 changes: 4 additions & 4 deletions persistence/sql/migratest/fixtures/settings_flow/77fe4fb3-2d4e-4532-b568-c44b0aece0aa.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -20,17 +20,17 @@
},
"verifiable_addresses": [
{
"id": "b2d59320-8564-4400-a39f-a22a497a23f1",
"value": "foobar+without-code@ory.sh",
"id": "c2427b6d-312b-46d9-9285-536db7ae11fd",
"value": "foobar@ory.sh",
"verified": false,
"via": "email",
"status": "pending",
"created_at": "2013-10-07T08:23:19Z",
"updated_at": "2013-10-07T08:23:19Z"
},
{
"id": "c2427b6d-312b-46d9-9285-536db7ae11fd",
"value": "foobar@ory.sh",
"id": "b2d59320-8564-4400-a39f-a22a497a23f1",
"value": "foobar+without-code@ory.sh",
"verified": false,
"via": "email",
"status": "pending",
Expand Down
8 changes: 4 additions & 4 deletions persistence/sql/migratest/fixtures/settings_flow/8248bb5d-8ef7-45e3-8e07-9e2003dd5352.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -20,17 +20,17 @@
},
"verifiable_addresses": [
{
"id": "b2d59320-8564-4400-a39f-a22a497a23f1",
"value": "foobar+without-code@ory.sh",
"id": "c2427b6d-312b-46d9-9285-536db7ae11fd",
"value": "foobar@ory.sh",
"verified": false,
"via": "email",
"status": "pending",
"created_at": "2013-10-07T08:23:19Z",
"updated_at": "2013-10-07T08:23:19Z"
},
{
"id": "c2427b6d-312b-46d9-9285-536db7ae11fd",
"value": "foobar@ory.sh",
"id": "b2d59320-8564-4400-a39f-a22a497a23f1",
"value": "foobar+without-code@ory.sh",
"verified": false,
"via": "email",
"status": "pending",
Expand Down
8 changes: 4 additions & 4 deletions persistence/sql/migratest/fixtures/settings_flow/90b4f970-b9ae-42bc-a0a7-73ec750e0aa1.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -20,17 +20,17 @@
},
"verifiable_addresses": [
{
"id": "b2d59320-8564-4400-a39f-a22a497a23f1",
"value": "foobar+without-code@ory.sh",
"id": "c2427b6d-312b-46d9-9285-536db7ae11fd",
"value": "foobar@ory.sh",
"verified": false,
"via": "email",
"status": "pending",
"created_at": "2013-10-07T08:23:19Z",
"updated_at": "2013-10-07T08:23:19Z"
},
{
"id": "c2427b6d-312b-46d9-9285-536db7ae11fd",
"value": "foobar@ory.sh",
"id": "b2d59320-8564-4400-a39f-a22a497a23f1",
"value": "foobar+without-code@ory.sh",
"verified": false,
"via": "email",
"status": "pending",
Expand Down
8 changes: 4 additions & 4 deletions persistence/sql/migratest/fixtures/settings_flow/a79bfcf1-68ae-49de-8b23-4f96921b8341.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -20,17 +20,17 @@
},
"verifiable_addresses": [
{
"id": "b2d59320-8564-4400-a39f-a22a497a23f1",
"value": "foobar+without-code@ory.sh",
"id": "c2427b6d-312b-46d9-9285-536db7ae11fd",
"value": "foobar@ory.sh",
"verified": false,
"via": "email",
"status": "pending",
"created_at": "2013-10-07T08:23:19Z",
"updated_at": "2013-10-07T08:23:19Z"
},
{
"id": "c2427b6d-312b-46d9-9285-536db7ae11fd",
"value": "foobar@ory.sh",
"id": "b2d59320-8564-4400-a39f-a22a497a23f1",
"value": "foobar+without-code@ory.sh",
"verified": false,
"via": "email",
"status": "pending",
Expand Down
8 changes: 4 additions & 4 deletions persistence/sql/migratest/fixtures/settings_flow/aeba85bd-1a8c-44bf-8fc3-3be83c01a3dc.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -20,17 +20,17 @@
},
"verifiable_addresses": [
{
"id": "b2d59320-8564-4400-a39f-a22a497a23f1",
"value": "foobar+without-code@ory.sh",
"id": "c2427b6d-312b-46d9-9285-536db7ae11fd",
"value": "foobar@ory.sh",
"verified": false,
"via": "email",
"status": "pending",
"created_at": "2013-10-07T08:23:19Z",
"updated_at": "2013-10-07T08:23:19Z"
},
{
"id": "c2427b6d-312b-46d9-9285-536db7ae11fd",
"value": "foobar@ory.sh",
"id": "b2d59320-8564-4400-a39f-a22a497a23f1",
"value": "foobar+without-code@ory.sh",
"verified": false,
"via": "email",
"status": "pending",
Expand Down
8 changes: 4 additions & 4 deletions persistence/sql/migratest/fixtures/settings_flow/cdfd1eed-34a4-491d-ad0a-7579d3a0a7ba.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -20,17 +20,17 @@
},
"verifiable_addresses": [
{
"id": "b2d59320-8564-4400-a39f-a22a497a23f1",
"value": "foobar+without-code@ory.sh",
"id": "c2427b6d-312b-46d9-9285-536db7ae11fd",
"value": "foobar@ory.sh",
"verified": false,
"via": "email",
"status": "pending",
"created_at": "2013-10-07T08:23:19Z",
"updated_at": "2013-10-07T08:23:19Z"
},
{
"id": "c2427b6d-312b-46d9-9285-536db7ae11fd",
"value": "foobar@ory.sh",
"id": "b2d59320-8564-4400-a39f-a22a497a23f1",
"value": "foobar+without-code@ory.sh",
"verified": false,
"via": "email",
"status": "pending",
Expand Down
8 changes: 0 additions & 8 deletions persistence/sql/persister_identity.go
View file
Original file line number Diff line number Diff line change
Expand Up @@ -458,14 +458,6 @@ func (p *Persister) GetIdentity(ctx context.Context, id uuid.UUID) (*identity.Id

i.Credentials = nil

if err := p.findVerifiableAddresses(ctx, &i); err != nil {
return nil, sqlcon.HandleError(err)
}

if err := p.findRecoveryAddresses(ctx, &i); err != nil {
return nil, sqlcon.HandleError(err)
}

if err := p.injectTraitsSchemaURL(ctx, &i); err != nil {
return nil, err
}
Expand Down

0 comments on commit cd625eb

Please sign in to comment.