feat: add error ids for csrf-related errors

ory · Oct 19, 2021 · dc2adbf · dc2adbf
1 parent 246a045
commit dc2adbf
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/x/nosurf.go b/x/nosurf.go
@@ -6,6 +6,8 @@ import (
 	"fmt"
 	"net/http"
 
+	"github.com/ory/kratos/text"
+
 	"github.com/ory/kratos/driver/config"
 
 	"github.com/pkg/errors"
@@ -17,7 +19,9 @@ import (
 )
 
 var (
-	ErrInvalidCSRFToken = herodot.ErrForbidden.WithError("the request was rejected to protect you from Cross-Site-Request-Forgery").
+	ErrInvalidCSRFToken = herodot.ErrForbidden.
+				WithID(text.ErrIDCSRF).
+				WithError("the request was rejected to protect you from Cross-Site-Request-Forgery").
 				WithDetail("docs", "https://www.ory.sh/kratos/docs/debug/csrf").
 				WithReason("The request was rejected to protect you from Cross-Site-Request-Forgery (CSRF) which could cause account takeover, leaking personal information, and other serious security issues.")
 	ErrGone = herodot.DefaultError{

diff --git a/x/nosurf_test.go b/x/nosurf_test.go
@@ -86,7 +86,7 @@ func TestNosurfBaseCookieErrorHandler(t *testing.T) {
 	expectError := func(t *testing.T, err error, req *http.Request) {
 		rec := httptest.NewRecorder()
 		h(rec, req)
-		assertx.EqualAsJSON(t, x.ErrInvalidCSRFTokenAJAXNoCookies, json.RawMessage(gjson.Get(rec.Body.String(), "error").Raw))
+		assertx.EqualAsJSON(t, err, json.RawMessage(gjson.Get(rec.Body.String(), "error").Raw))
 	}
 
 	newAjaxRequest := func() *http.Request {