Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document how oidc merges data from form and OP #127

Closed
aeneasr opened this issue Nov 22, 2019 · 0 comments · Fixed by #394
Closed

Document how oidc merges data from form and OP #127

aeneasr opened this issue Nov 22, 2019 · 0 comments · Fixed by #394

Comments

@aeneasr
Copy link
Member

aeneasr commented Nov 22, 2019

Is your feature request related to a problem? Please describe.

We need to better document how the oidc strategy merges data.

Describe the solution you'd like

Looking at the code, the process seems to be as follows:

  1. Hitting "sign up with ..." makes a POST request to /auth/browser/methods/oidc/auth/:request
  • After completing OIDC dance, we hit /auth/browser/methods/oidc/callback/:provider
  • If the identity schema can not be validated (e.g. the OP didn't return an email address), we return back to the registration UI with some error context (e.g. email is missing). Here, we expect to have all the fields with their values (e.g. username) set in oidc.ReuqestMethod.Config.Fields. This data is the result of applying the oidc schema and following the "mappings".
  • The user fills out some of the data and makes another POST request to /auth/browser/methods/oidc/auth/:request, this time with a form field like email: foo@bar.
@aeneasr aeneasr added this to the v0.0.1 milestone Dec 2, 2019
@aeneasr aeneasr added this to To do in Maintainer's Board via automation Jan 21, 2020
@aeneasr aeneasr moved this from To do to Priority in Maintainer's Board Jan 21, 2020
@aeneasr aeneasr moved this from Priority to To do in Maintainer's Board Jan 27, 2020
@aeneasr aeneasr removed this from To do in Maintainer's Board Jan 27, 2020
@aeneasr aeneasr added this to To do in Maintainer's Board via automation Feb 3, 2020
@aeneasr aeneasr modified the milestones: v0.2.0-alpha.1, v0.2.1-alpha.1 May 2, 2020
Maintainer's Board automation moved this from To do to Done May 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging a pull request may close this issue.

1 participant