Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logout Http Code doesn't match Docs #1648

Closed
like-a-bause opened this issue Aug 13, 2021 · 3 comments
Closed

Logout Http Code doesn't match Docs #1648

like-a-bause opened this issue Aug 13, 2021 · 3 comments
Labels
stale Feedback from one or more authors is required to proceed.
Milestone

Comments

@like-a-bause
Copy link
Contributor

A successful logout results in a 303:

http.Redirect(w, r, ret.String(), http.StatusSeeOther)

the documentation however states a 302:
// 302: emptyResponse

I don't know if this change was made intentionally or by mistake. One of these lines needs to be updated.

@aeneasr
Copy link
Member

aeneasr commented Aug 16, 2021

Thank you! Feel free to correct it in a PR :)

@aeneasr aeneasr added this to the v0.10.0-alpha.1 milestone Mar 7, 2022
@aeneasr aeneasr modified the milestones: v0.10.0-alpha.1, v1.0.0 May 30, 2022
@robertlagrant
Copy link

robertlagrant commented Apr 21, 2023

@aeneasr I think this is now closeable. Looks fixed.

// 303: emptyResponse

Copy link

Hello contributors!

I am marking this issue as stale as it has not received any engagement from the community or maintainers for a year. That does not imply that the issue has no merit! If you feel strongly about this issue

  • open a PR referencing and resolving the issue;
  • leave a comment on it and discuss ideas on how you could contribute towards resolving it;
  • leave a comment and describe in detail why this issue is critical for your use case;
  • open a new issue with updated details and a plan for resolving the issue.

Throughout its lifetime, Ory has received over 10.000 issues and PRs. To sustain that growth, we need to prioritize and focus on issues that are important to the community. A good indication of importance, and thus priority, is activity on a topic.

Unfortunately, burnout has become a topic of concern amongst open-source projects.

It can lead to severe personal and health issues as well as opening catastrophic attack vectors.

The motivation for this automation is to help prioritize issues in the backlog and not ignore, reject, or belittle anyone.

If this issue was marked as stale erroneously you can exempt it by adding the backlog label, assigning someone, or setting a milestone for it.

Thank you for your understanding and to anyone who participated in the conversation! And as written above, please do participate in the conversation if this topic is important to you!

Thank you 🙏✌️

@github-actions github-actions bot added the stale Feedback from one or more authors is required to proceed. label Apr 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale Feedback from one or more authors is required to proceed.
Projects
None yet
Development

No branches or pull requests

3 participants