Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Session cookie (ory_kratos_session) expired time should be configurable #326

Closed
duytruong opened this issue Apr 9, 2020 · 2 comments
Closed
Assignees
Labels
feat New feature or request.

Comments

@duytruong
Copy link

Is your feature request related to a problem? Please describe.

Currently, session cookies expires after 1 month.

Describe the solution you'd like

Session cookie (ory_kratos_session) expired time should be configurable. A ttl.session config already exists in the code base but can't be used, IMO schema config doesn't add this field atm.

Describe alternatives you've considered

Additional context

Add any other context or screenshots about the feature request here.

@duytruong duytruong changed the title Session cookie (ory_kratos_session) expired time should be configurable Session cookie (ory_kratos_session) expired time should be configurable Apr 9, 2020
@duytruong
Copy link
Author

It's good if you let me know where to start :)

@aeneasr
Copy link
Member

aeneasr commented Apr 10, 2020

The current key is kind of old, I don't think we should use it! Instead, it would make sense to add a ttl to the session hook config around here (see example config for redirection hook). This would need tests and the Configuration Schema also needs to be updated around here

@aeneasr aeneasr added this to the v0.4.0-alpha.1 milestone Apr 29, 2020
aeneasr added a commit that referenced this issue Jul 27, 2020
@aeneasr aeneasr self-assigned this Jul 27, 2020
@aeneasr aeneasr added the feat New feature or request. label Jul 27, 2020
@aeneasr aeneasr added this to To do in Maintainer's Board via automation Jul 27, 2020
Maintainer's Board automation moved this from To do to Done Jul 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat New feature or request.
Projects
Development

No branches or pull requests

2 participants