Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add error checking when creating verification code #3328

Merged
merged 1 commit into from Jun 19, 2023

Conversation

hperl
Copy link
Contributor

@hperl hperl commented Jun 19, 2023

Related issue(s)

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    security@ory.sh) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

@hperl hperl requested a review from jonas-jonas June 19, 2023 11:53
@hperl hperl self-assigned this Jun 19, 2023
@codecov
Copy link

codecov bot commented Jun 19, 2023

Codecov Report

Merging #3328 (b4c2cf3) into master (3485204) will decrease coverage by 0.11%.
The diff coverage is 71.42%.

❗ Current head b4c2cf3 differs from pull request most recent head 266a5a9. Consider uploading reports for the commit 266a5a9 to get more accurate results

@@            Coverage Diff             @@
##           master    #3328      +/-   ##
==========================================
- Coverage   78.20%   78.09%   -0.11%     
==========================================
  Files         325      325              
  Lines       21079    21080       +1     
==========================================
- Hits        16484    16463      -21     
- Misses       3370     3386      +16     
- Partials     1225     1231       +6     
Impacted Files Coverage Δ
persistence/sql/persister_verification.go 83.12% <66.66%> (-1.16%) ⬇️
selfservice/strategy/code/verification_code.go 50.00% <100.00%> (ø)

... and 3 files with indirect coverage changes

@aeneasr aeneasr merged commit 7182eca into master Jun 19, 2023
30 checks passed
@aeneasr aeneasr deleted the hperl/fix-foreign-key-constraint-violation branch June 19, 2023 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants