docs: Docker image documentation #573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aeneasr
reviewed
Jul 13, 2020
| FROM oryd/kratos:latest | ||
| COPY contrib/quickstart/kratos/email-password/.kratos.yml /ory/home | ||
| ``` | ||
|
|
There was a problem hiding this comment.
I would add a warning here that it's not good practice to copy config into docker images but that it's a good and dirty workaround to get started
There was a problem hiding this comment.
In my opinion unless we are talking about secrets or environment specific configuration the config can be part of Docker image. Normally you would add it as part of the last fs layer.
This allows to propagate the Docker image with the base configuration from env to env. But this is only how we handled it at work. Feedback welcome @kevgo @k9ert
Co-authored-by: hackerman <3372410+aeneasr@users.noreply.github.com>
Co-authored-by: hackerman <3372410+aeneasr@users.noreply.github.com>
Co-authored-by: hackerman <3372410+aeneasr@users.noreply.github.com>
|
🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
As the official Docker images provided by Ory are the recommend way to run Kratos, we should provide more details on the different image types and how the images can be used.
This is only
Checklist
vulnerability. If this pull request addresses a security. vulnerability, I
confirm that I got green light (please contact
security@ory.sh) from the maintainers to push
the changes.
works.