New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Docker image documentation #573
Conversation
FROM oryd/kratos:latest | ||
COPY contrib/quickstart/kratos/email-password/.kratos.yml /ory/home | ||
``` | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would add a warning here that it's not good practice to copy config into docker images but that it's a good and dirty workaround to get started
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In my opinion unless we are talking about secrets or environment specific configuration the config can be part of Docker image. Normally you would add it as part of the last fs layer.
This allows to propagate the Docker image with the base configuration from env to env. But this is only how we handled it at work. Feedback welcome @kevgo @k9ert
Co-authored-by: hackerman <3372410+aeneasr@users.noreply.github.com>
Co-authored-by: hackerman <3372410+aeneasr@users.noreply.github.com>
Co-authored-by: hackerman <3372410+aeneasr@users.noreply.github.com>
🎉 |
Proposed changes
As the official Docker images provided by Ory are the recommend way to run Kratos, we should provide more details on the different image types and how the images can be used.
This is only
Checklist
vulnerability. If this pull request addresses a security. vulnerability, I
confirm that I got green light (please contact
security@ory.sh) from the maintainers to push
the changes.
works.