Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove reverse proxy from node example and rely on port and the domain parameter #661

Closed
5 tasks
aeneasr opened this issue Aug 24, 2020 · 4 comments
Closed
5 tasks
Assignees
Labels
blocking Blocks milestones or other issues or pulls. corp/m2 Up for M2 at Ory Corp.

Comments

@aeneasr
Copy link
Member

aeneasr commented Aug 24, 2020

Is your feature request related to a problem? Please describe.

The current set up uses a reverse proxy in the node example app to allow ORY Kratos to set cookies for that domain. However, cookies do not distinguish between ports (all ports of a domain will get the cookies) because, for example, TLS runs on 443 and HTTP on 80.

We also have control over the cookie domain now which would allow us to set a cookie for a TLD (example.org) from a subdomain (sub.example.org).

Describe the solution you'd like

  • Remove the code from the selfservice example app
  • Remove all references in the documentation for this set up
  • Remove it from the quickstart set up
  • Document a git commit message to alert people about this change as it will de-complicate their set up
  • CORS configuration
@aeneasr aeneasr added docs blocking Blocks milestones or other issues or pulls. corp/m2 Up for M2 at Ory Corp. labels Aug 24, 2020
@aeneasr aeneasr added this to the v0.5.0-alpha.1 milestone Aug 24, 2020
@aeneasr aeneasr self-assigned this Aug 24, 2020
aeneasr added a commit to ory/kratos-selfservice-ui-node that referenced this issue Aug 24, 2020
aeneasr added a commit that referenced this issue Aug 24, 2020
Closes #661

BREAKING CHANGE: This patch makes the reverse proxy functionality required in prior versions of the self-service UI example obsolete. All examples work now with a simple set up and documentation has been added to assist in subdomain scenarios.
@blakepettersson
Copy link

For this to work smoothly for client-side JS apps, we would also need to have the ability to set CORS headers in Kratos.

@aeneasr
Copy link
Member Author

aeneasr commented Aug 28, 2020

Yup, makes sense!

aeneasr added a commit to ory/kratos-selfservice-ui-node that referenced this issue Sep 1, 2020
@wilcoschoneveld
Copy link

@aeneasr setting CORS headers in Kratos is not yet possible right?

@aeneasr
Copy link
Member Author

aeneasr commented Sep 30, 2020

#712

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocking Blocks milestones or other issues or pulls. corp/m2 Up for M2 at Ory Corp.
Projects
None yet
Development

No branches or pull requests

3 participants