New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: adds missing gitlab to list of supported oidc providers #766
Conversation
Nice catch, could you automate that list generation though? That way it will be always up to date. |
Sorry for the crude example but I hope it explains the idea. |
You can omit the custom type though and just go with strings, that should be fine. |
https://github.com/ory/kratos/blob/master/selfservice/strategy/oidc/provider_config.go#L19-L21 is also out of date, sorry for all the spam. |
Sure. I also thought about refactoring this but my second thought was maybe it's on purpose for simplicity or something. |
I guess it was because of laziness by @aeneasr 😉 |
|
Looking good, Ah you tried that already, I see. |
Proposed changes
Adds gitlab to list of supported providers in error message.
Checklist
vulnerability. If this pull request addresses a security. vulnerability, I
confirm that I got green light (please contact
security@ory.sh) from the maintainers to push
the changes.
works.