Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: adds missing gitlab to list of supported oidc providers #766

Merged
merged 2 commits into from Oct 14, 2020

Conversation

NickUfer
Copy link
Contributor

Proposed changes

Adds gitlab to list of supported providers in error message.

Checklist

  • I have read the contributing guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security. vulnerability, I
    confirm that I got green light (please contact
    security@ory.sh) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

@NickUfer NickUfer changed the title fix: adds gitlab to list of supported oidc providers fix: adds missing gitlab to list of supported oidc providers Oct 14, 2020
@zepatrik
Copy link
Member

Nice catch, could you automate that list generation though? That way it will be always up to date.
My suggestion would be to use a pattern similar to this: https://play.golang.org/p/ktNUWwnWb9R

@zepatrik
Copy link
Member

Sorry for the crude example but I hope it explains the idea.

@zepatrik
Copy link
Member

zepatrik commented Oct 14, 2020

You can omit the custom type though and just go with strings, that should be fine.
The custom type would only have the benefit to force people to use the case registering function.

@zepatrik
Copy link
Member

@NickUfer
Copy link
Contributor Author

Nice catch, could you automate that list generation though? That way it will be always up to date.
My suggestion would be to use a pattern similar to this: https://play.golang.org/p/ktNUWwnWb9R

Sure. I also thought about refactoring this but my second thought was maybe it's on purpose for simplicity or something.

@zepatrik
Copy link
Member

I guess it was because of laziness by @aeneasr 😉

@NickUfer
Copy link
Contributor Author

NickUfer commented Oct 14, 2020

hope this is not too over engineered
Okay yeah this is over engineered, I will try your approach 😄

@zepatrik
Copy link
Member

zepatrik commented Oct 14, 2020

Looking good, one other idea I had was to use the python switch approach. You would have to iterate over the map but I think this is nicer 😉

Ah you tried that already, I see.

@zepatrik zepatrik merged commit a43ed33 into ory:master Oct 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants