Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix a redirect specified in play-by-play steps #1626

Merged
merged 2 commits into from
Aug 7, 2021

Conversation

carloschida
Copy link
Contributor

Since we are running the quick-start locally —at least most will— the actual location of the redirect is http://127.0.0.1:4433/self-service/login/browser and not the one starting with https://playground.projects.oryapis.com/api/kratos/public.

Related issue(s)

None

Checklist

  • [ x] I have read the contributing guidelines.
  • [ x] I am following the
    contributing code guidelines.
  • [ x] I have read the security policy.
  • [ x] I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security. vulnerability, I
    confirm that I got green light (please contact
    security@ory.sh) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • [x ] I have added or changed the documentation.

Further Comments

Just a tiny documentation fix.

Since we are running the quick-start locally —at least most will— the actual location of the redirect is `http://127.0.0.1:4433/self-service/login/browser` and not the one starting with  `https://playground.projects.oryapis.com/api/kratos/public`.
@CLAassistant
Copy link

CLAassistant commented Aug 5, 2021

CLA assistant check
All committers have signed the CLA.

@carloschida carloschida changed the title Fix a redirect specified in play-by-play steps docs: fix a redirect specified in play-by-play steps Aug 5, 2021
@codecov
Copy link

codecov bot commented Aug 5, 2021

Codecov Report

Merging #1626 (6b9dd98) into master (b6215a0) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1626   +/-   ##
=======================================
  Coverage   74.25%   74.25%           
=======================================
  Files         259      259           
  Lines       12618    12618           
=======================================
  Hits         9370     9370           
  Misses       2627     2627           
  Partials      621      621           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b6215a0...6b9dd98. Read the comment docs.

Copy link
Member

@zepatrik zepatrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The idea is that you can use the remote playground Kratos for the quickstart or tutorials, without the need for getting it running first. But you are right, in this context that is neither explained nor useful as previous URLs are localhost and you also start Kratos using docker compose.
Tracked that as #1635.

@zepatrik zepatrik merged commit bae1847 into ory:master Aug 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants