-
-
Notifications
You must be signed in to change notification settings - Fork 930
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: change model to schema #1639
Conversation
id: identity-data-model | ||
title: Identity Data Model | ||
id: identity-schema | ||
title: Identity Schema |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does the SEO say? 🤔 🦊
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I search for Identity Data Model
our doc is placed 2.
For Identity Schema
we are in place 3 (just after ms azure docs ;) )
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there anything else I didn't consider?
We probably have to add the old
identity-data-models
to https://github.com/ory/web/blob/master/static/_redirects ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know much about SEO, but changing URLs is always not as easy as just changing it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will need a PR for in here:
https://github.com/ory/web/blob/1fa63437980966acfbfec8ac55a8601ba127962c/static/_redirects#L252
Codecov Report
@@ Coverage Diff @@
## master #1639 +/- ##
==========================================
- Coverage 74.27% 74.25% -0.02%
==========================================
Files 259 259
Lines 12618 12618
==========================================
- Hits 9372 9370 -2
- Misses 2626 2627 +1
- Partials 620 621 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM :)
id: identity-data-model | ||
title: Identity Data Model | ||
id: identity-schema | ||
title: Identity Schema |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will need a PR for in here:
https://github.com/ory/web/blob/1fa63437980966acfbfec8ac55a8601ba127962c/static/_redirects#L252
PR for the redirects: |
Thank you! |
Related issue(s)
This PR changes the term
Identity Model
toIdentity Schema
;capitalizing it in all instances, since it is an Ory specific term and will be documented in a glossary soon.
Changes have been made for the
next
and0.7
versions.Also changed instances of
Identity JSON Schema
Identity Schema JSON
JSON Schemas for Identities
to
Identity Model
Have tested with
npm run build
and found no broken links.This commit e6d420a makes the required changes in API documentation. (Please let me know if this is the correct location).
Checklist
contributing code guidelines.
vulnerability. If this pull request addresses a security. vulnerability, I
confirm that I got green light (please contact
security@ory.sh) from the maintainers to push
the changes.
works.
Further Comments