fix: facebook connect bug

[abador]

After updating to version 0.7 Facebook Connect stopped working and we can find errors in the logs:

Unable to initialize OpenID Connect Provider: oidc: issuer did not match the issuer returned by provider, expected \"https://facebook.com\" got \"https://www.facebook.com\"

It's a minimal change that adds www to the issuer url

Related issue(s)

#1687

#1686

Checklist

• I have read the contributing guidelines.
• I am following the
  contributing code guidelines.
• I have read the security policy.
• I confirm that this pull request does not address a security
  vulnerability. If this pull request addresses a security. vulnerability, I
  confirm that I got green light (please contact
  security@ory.sh) from the maintainers to push
  the changes.
• I have added tests that prove my fix is effective or that my feature
  works.
• I have added or changed the documentation.

Further Comments

[CLAassistant]

All committers have signed the CLA.

[abador]

@aeneasr what's your opinion on adding tests to all provider implementations? It seems that none of them have any tests, except for the generic one. Was that intentional? Not sure if adding tests only to the Facebook provider is the way to go. Maybe this should be done separately?

[aeneasr]

I would love to have tests for those - the problem is that most social sign in providers detect CIs and automation and require solving CAPTCHAs for login. So unless we mock the payloads (which would not have caught this particular bug) I don't see a lot of possibilities here. Or is there some framework or something we could use?

[aeneasr]

Thank you, this looks great! It looks like the CLA bot is not properly detecting your signature. To fix this, try the following:

$ git commit  --amend --author="Author Name <email@address.com>"

Ensure that Author Name is replaced with your GitHub username (e.g. aeneasr) and that the email address is replaced with the email address you have set up in GitHub (e.g. 3372410+aeneasr@users.noreply.github.com):

$ git commit  --amend --author="aeneasr <3372410+aeneasr@users.noreply.github.com>"

Once that is done, you can force-push your changes (make sure to push to the correct remote and branch!):

$ git push --force <remote> HEAD:<branch>

[Amarantine84]

Guys,
This one seems a bit critical.
Looking forward to get the issue fixed.

[abador]

Sorry for that @aeneasr it seems that after reinstalling the system I set the wrong git config :)

[aeneasr]

I'll look into the e2e tests now

[aeneasr]

It should be resolved now, will check again once CI passed

[codecov]

Codecov Report

Merging #1689 (4f88ae1) into master (1ba6c4a) will decrease coverage by 0.11%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##           master    #1689      +/-   ##
==========================================
- Coverage   74.25%   74.14%   -0.12%     
==========================================
  Files         259      259              
  Lines       12618    12618              
==========================================
- Hits         9370     9356      -14     
- Misses       2627     2638      +11     
- Partials      621      624       +3     

Impacted Files	Coverage Δ
selfservice/strategy/oidc/provider_facebook.go	0.00% <0.00%> (ø)
driver/config/config.go	82.00% <100.00%> (ø)
courier/courier.go	57.35% <0.00%> (-10.30%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b863a82...4f88ae1. Read the comment docs.