New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Advanced e-mail templating support #1859
feat: Advanced e-mail templating support #1859
Conversation
* Made Sprig functions available to templates * Made the identity of the recipient available to templates * Implemented support for nested templates
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking pretty good already, thanks a lot 👍
I have some ideas how to improve it further 😉
@zepatrik I've fixed everything in accordance with your suggestions in a separate commit, plus a few more changes I had to make to get your suggestions to compile and run. Also, there are some issues with the e2e test, but I don't think that's something I caused:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking great so far! I think we can extract the template interface with Execute
into a common type, that would make code readability easier and also avoid duplication :)
Codecov Report
@@ Coverage Diff @@
## master #1859 +/- ##
==========================================
- Coverage 75.19% 75.13% -0.06%
==========================================
Files 292 292
Lines 15180 15241 +61
==========================================
+ Hits 11414 11451 +37
- Misses 2953 2965 +12
- Partials 813 825 +12
Continue to review full report at Codecov.
|
…hub.com/avamonitoring/kratos into feat-advanced-e-mail-templating-support
Great job! |
This PR adds more advanced templating functionality to courier messages by
Related issue(s)
closes #834
closes #925
Checklist
contributing code guidelines.
vulnerability. If this pull request addresses a security. vulnerability, I
confirm that I got green light (please contact
security@ory.sh) from the maintainers to push
the changes.
works.
Further Comments
N/A