Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: remove unintended characters in subdomain section in csrf page #1897

Merged
merged 1 commit into from Oct 29, 2021

Conversation

yonbh
Copy link
Contributor

@yonbh yonbh commented Oct 28, 2021

Small corrections to subdomain section in csrf debug page.

Related issue(s)

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security. vulnerability, I
    confirm that I got green light (please contact
    security@ory.sh) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

@CLAassistant
Copy link

CLAassistant commented Oct 28, 2021

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Oct 28, 2021

Codecov Report

Merging #1897 (9fec612) into master (1e794fe) will decrease coverage by 0.06%.
The diff coverage is n/a.

❗ Current head 9fec612 differs from pull request most recent head f907c82. Consider uploading reports for the commit f907c82 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1897      +/-   ##
==========================================
- Coverage   75.13%   75.07%   -0.07%     
==========================================
  Files         292      292              
  Lines       15127    15125       -2     
==========================================
- Hits        11366    11355      -11     
- Misses       2950     2958       +8     
- Partials      811      812       +1     
Impacted Files Coverage Δ
cmd/courier/watch.go 60.34% <0.00%> (-12.07%) ⬇️
internal/testhelpers/e2e_server.go 87.82% <0.00%> (-1.74%) ⬇️
persistence/sql/persister_recovery.go 79.54% <0.00%> (-0.46%) ⬇️
selfservice/strategy/link/token_recovery.go 100.00% <0.00%> (ø)
selfservice/strategy/link/test/persistence.go 100.00% <0.00%> (ø)
selfservice/strategy/link/strategy_recovery.go 65.08% <0.00%> (+0.92%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ac7efc3...f907c82. Read the comment docs.

Copy link
Member

@aeneasr aeneasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

@yonbh yonbh force-pushed the docs/cleanup-csrf-subdomain-section branch from 9fec612 to f907c82 Compare October 29, 2021 09:03
@aeneasr aeneasr merged commit dfb9007 into ory:master Oct 29, 2021
@yonbh yonbh deleted the docs/cleanup-csrf-subdomain-section branch October 29, 2021 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants