Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: adds missing webauthn authentication method #1914

Merged

Conversation

NickUfer
Copy link
Contributor

Related issue(s)

Fixes #1913

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security. vulnerability, I
    confirm that I got green light (please contact
    security@ory.sh) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

@codecov
Copy link

codecov bot commented Nov 1, 2021

Codecov Report

Merging #1914 (39871c8) into master (bf80e96) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1914      +/-   ##
==========================================
+ Coverage   75.19%   75.21%   +0.01%     
==========================================
  Files         292      292              
  Lines       15169    15169              
==========================================
+ Hits        11407    11409       +2     
+ Misses       2951     2950       -1     
+ Partials      811      810       -1     
Impacted Files Coverage Δ
internal/testhelpers/e2e_server.go 89.56% <0.00%> (+1.73%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bf80e96...39871c8. Read the comment docs.

@aeneasr aeneasr merged commit 44892f3 into ory:master Nov 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OpenAPI Sdk: Invalid value 'webauthn' for 'method', must be one of 'link_recovery', 'password', 'totp', 'oidc'
2 participants