Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(debug): fix typo #1976

Merged
merged 2 commits into from Nov 23, 2021
Merged

docs(debug): fix typo #1976

merged 2 commits into from Nov 23, 2021

Conversation

ryanvanoss
Copy link
Contributor

@ryanvanoss ryanvanoss commented Nov 23, 2021

Related issue(s)

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security. vulnerability, I
    confirm that I got green light (please contact
    security@ory.sh) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

@CLAassistant
Copy link

CLAassistant commented Nov 23, 2021

CLA assistant check
All committers have signed the CLA.

@ryanvanoss ryanvanoss changed the title fix typo docs(debug): fix typo Nov 23, 2021
@ryanvanoss ryanvanoss marked this pull request as draft November 23, 2021 01:50
@ryanvanoss ryanvanoss marked this pull request as ready for review November 23, 2021 01:55
@aeneasr
Copy link
Member

aeneasr commented Nov 23, 2021

Thank you very much for your contribution to the documentation! Due to the way Docusaurus versioning works, you need to make the changes in two locations:

  • docs/versioned_docs/version-v{version}/path/to/file
  • docs/docs/path/to/file

Without making them in both locations, the changes will most likely be lost when releasing another version. Thank you! :)

@ryanvanoss
Copy link
Contributor Author

Np @aeneasr :)

Do you want me to fix 0.2-0.7 too, or just leave them as-is?

@aeneasr
Copy link
Member

aeneasr commented Nov 23, 2021

You can leave as is :) Thank you! :)

@aeneasr aeneasr merged commit 0647554 into ory:master Nov 23, 2021
peturgeorgievv pushed a commit to senteca/kratos-fork that referenced this pull request Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants