Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cmd): add oidc credential include #2017

Merged
merged 4 commits into from Dec 6, 2021
Merged

feat(cmd): add oidc credential include #2017

merged 4 commits into from Dec 6, 2021

Conversation

alexandrebrg
Copy link
Contributor

@alexandrebrg alexandrebrg commented Dec 1, 2021 •
edited

Related issue(s)

Implement this #1970

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security. vulnerability, I
    confirm that I got green light (please contact
    security@ory.sh) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

This is my first contrib 馃コ

@alexandrebrg alexandrebrg marked this pull request as ready for review December 2, 2021 12:39
zepatrik
zepatrik requested changes Dec 2, 2021
View reviewed changes
Copy link
Member

@zepatrik zepatrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor improvements 馃憤

cmd/identities/get.go Outdated Show resolved Hide resolved
cmd/identities/get.go Outdated Show resolved Hide resolved
@alexandrebrg alexandrebrg force-pushed the add-inc-creds-args branch 3 times, most recently from 282e332 to 90215b1 Compare December 4, 2021 19:06
zepatrik
zepatrik requested changes Dec 6, 2021
View reviewed changes
Copy link
Member

@zepatrik zepatrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for coming back to this 馃憤

cmd/identities/get.go Outdated Show resolved Hide resolved
cmd/identities/get.go Show resolved Hide resolved
@zepatrik zepatrik merged commit 1482844 into ory:master Dec 6, 2021
@zepatrik
Copy link
Member

zepatrik commented Dec 6, 2021

Thanks again 馃憤

peturgeorgievv pushed a commit to senteca/kratos-fork that referenced this pull request Jun 30, 2023
@alexandrebrg @zepatrik
feat(cmd): add OIDC credential include (ory#2017)
fb0f74b 
With this change, the `kratos identities get` CLI can additionally fetch OIDC credentials.

Co-authored-by: Patrik <zepatrik@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zepatrik zepatrik zepatrik requested changes

@aeneasr aeneasr Awaiting requested review from aeneasr aeneasr is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@alexandrebrg @zepatrik