Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: improve text around bcrypt #2037

Merged
merged 1 commit into from Dec 8, 2021
Merged

docs: improve text around bcrypt #2037

merged 1 commit into from Dec 8, 2021

Conversation

mitar
Copy link
Contributor

@mitar mitar commented Dec 7, 2021

I think this is closer to how things are implemented, from what I have observed in the current code. So password is not silently truncated, but an error is returned. Also, the limit of 72 bytes (not characters!) is a property of the bcrypt algorithm itself and not the implementation.

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security. vulnerability, I
    confirm that I got green light (please contact
    security@ory.sh) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Copy link
Member

@aeneasr aeneasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

@aeneasr aeneasr merged commit ba6981e into ory:master Dec 8, 2021
peturgeorgievv pushed a commit to senteca/kratos-fork that referenced this pull request Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants