Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sdk): add cookie headers to all form submissions #2467

Merged
merged 1 commit into from
May 13, 2022
Merged

Conversation

aeneasr
Copy link
Member

@aeneasr aeneasr commented May 13, 2022

Closes #2003
Closes #2454

Related issue(s)

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security. vulnerability, I
    confirm that I got green light (please contact
    security@ory.sh) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

@codecov
Copy link

codecov bot commented May 13, 2022

Codecov Report

Merging #2467 (79dbfd9) into master (50bdba9) will increase coverage by 0.03%.
The diff coverage is 100.00%.

❗ Current head 79dbfd9 differs from pull request most recent head 2b95c22. Consider uploading reports for the commit 2b95c22 to get more accurate results

@@            Coverage Diff             @@
##           master    #2467      +/-   ##
==========================================
+ Coverage   76.52%   76.55%   +0.03%     
==========================================
  Files         316      316              
  Lines       17596    17600       +4     
==========================================
+ Hits        13465    13474       +9     
+ Misses       3197     3192       -5     
  Partials      934      934              
Impacted Files Coverage Δ
selfservice/flow/login/handler.go 80.83% <ø> (ø)
selfservice/flow/recovery/handler.go 62.50% <ø> (ø)
selfservice/flow/registration/handler.go 78.57% <ø> (ø)
selfservice/flow/settings/handler.go 68.91% <ø> (ø)
selfservice/flow/verification/handler.go 65.09% <ø> (ø)
courier/smtp.go 75.00% <100.00%> (+0.42%) ⬆️
driver/config/config.go 82.05% <100.00%> (+0.05%) ⬆️
ui/node/attributes.go 60.86% <100.00%> (ø)
ui/node/node.go 90.65% <100.00%> (ø)
persistence/sql/persister_courier.go 89.70% <0.00%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2bffee8...2b95c22. Read the comment docs.

@aeneasr aeneasr merged commit 9a969fd into master May 13, 2022
@aeneasr aeneasr deleted the cookie branch May 13, 2022 16:19
peturgeorgievv pushed a commit to senteca/kratos-fork that referenced this pull request Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

POST /self-service/registration route not accepting CSRF token
1 participant