Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Oauth2 integration #2804

Merged
merged 37 commits into from
Oct 26, 2022
Merged

feat: Oauth2 integration #2804

merged 37 commits into from
Oct 26, 2022

Conversation

aeneasr
Copy link
Member

@aeneasr aeneasr commented Oct 14, 2022

Related issue(s)

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    security@ory.sh) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

@aeneasr aeneasr marked this pull request as ready for review October 15, 2022 08:54
grantzvolsky and others added 26 commits October 23, 2022 00:44
This commit removes the --e2e cypress option because it is broken in the
current release. There is an unreleased fix[1], so we may re-add it later, but
it isn't necessary because --e2e is the default.

[1]: cypress-io/cypress#22829
When using Kratos with Hydra as an OIDC IDP, the Kratos options

* session.cookie.persistent and
* session.lifespan

now also apply to third party login.
@aeneasr aeneasr merged commit 7c6eb2a into master Oct 26, 2022
@aeneasr aeneasr deleted the oauth2-integration-review branch October 26, 2022 07:55
@mitar mitar mentioned this pull request Oct 26, 2022
7 tasks
peturgeorgievv pushed a commit to senteca/kratos-fork that referenced this pull request Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants