Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: webhook tracing and missing defers #3145

Merged
merged 1 commit into from Mar 6, 2023
Merged

fix: webhook tracing and missing defers #3145

merged 1 commit into from Mar 6, 2023

Conversation

alnr
Copy link
Contributor

@alnr alnr commented Mar 4, 2023

Found by @jonas-jonas here (thanks!)

The webhook tracing was broken in the last refactoring. This change restores the correct passing of span contexts, and also re-enables retries. Previously, all attempts were aborted after a total of 30s. Now, we get 30s for each attempt.

@codecov
Copy link

codecov bot commented Mar 4, 2023

Codecov Report

Merging #3145 (514d177) into master (ceb5cc2) will decrease coverage by 0.03%.
The diff coverage is 93.33%.

❗ Current head 514d177 differs from pull request most recent head 46677a3. Consider uploading reports for the commit 46677a3 to get more accurate results

@@            Coverage Diff             @@
##           master    #3145      +/-   ##
==========================================
- Coverage   77.58%   77.56%   -0.03%     
==========================================
  Files         316      316              
  Lines       19908    19906       -2     
==========================================
- Hits        15446    15440       -6     
- Misses       3273     3276       +3     
- Partials     1189     1190       +1     
Impacted Files Coverage Δ
persistence/sql/identity/persister_identity.go 76.64% <92.85%> (ø)
selfservice/hook/web_hook.go 78.70% <100.00%> (-0.17%) ⬇️
session/test/persistence.go 99.05% <0.00%> (-0.95%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@jonas-jonas jonas-jonas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks for fixing this so quickly! :)

@aeneasr aeneasr merged commit 46eb063 into master Mar 6, 2023
@aeneasr aeneasr deleted the missing-defers branch March 6, 2023 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants