Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: re-use existing CSRF token in verification flows #3188

Merged
merged 2 commits into from Mar 27, 2023

Conversation

jonas-jonas
Copy link
Contributor

@jonas-jonas jonas-jonas commented Mar 27, 2023

Related issue(s)

Fixes ory-corp/cloud/issues/4283

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    security@ory.sh) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

@codecov
Copy link

codecov bot commented Mar 27, 2023

Codecov Report

Merging #3188 (29e7c9c) into master (590269f) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 29e7c9c differs from pull request most recent head f97eda0. Consider uploading reports for the commit f97eda0 to get more accurate results

@@           Coverage Diff           @@
##           master    #3188   +/-   ##
=======================================
  Coverage   77.68%   77.68%           
=======================================
  Files         319      319           
  Lines       20159    20162    +3     
=======================================
+ Hits        15660    15663    +3     
- Misses       3300     3301    +1     
+ Partials     1199     1198    -1     
Impacted Files Coverage Δ
selfservice/hook/verification.go 75.60% <100.00%> (+1.92%) ⬆️

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@hperl hperl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🎉

@hperl hperl merged commit 08a3447 into master Mar 27, 2023
26 checks passed
@hperl hperl deleted the jonas-jonas/fix/csrfIssueSettings branch March 27, 2023 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants