Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bump quickstart version #3257

Merged
merged 1 commit into from Apr 27, 2023
Merged

fix: bump quickstart version #3257

merged 1 commit into from Apr 27, 2023

Conversation

vinckr
Copy link
Member

@vinckr vinckr commented Apr 26, 2023

Related issue(s)

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    security@ory.sh) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

@codecov
Copy link

codecov bot commented Apr 26, 2023

Codecov Report

Merging #3257 (ab378ec) into master (349d0ee) will increase coverage by 0.15%.
The diff coverage is 72.14%.

❗ Current head ab378ec differs from pull request most recent head 1cb18c8. Consider uploading reports for the commit 1cb18c8 to get more accurate results

@@            Coverage Diff             @@
##           master    #3257      +/-   ##
==========================================
+ Coverage   77.90%   78.06%   +0.15%     
==========================================
  Files         319      319              
  Lines       20449    20398      -51     
==========================================
- Hits        15931    15923       -8     
+ Misses       3320     3288      -32     
+ Partials     1198     1187      -11     
Impacted Files Coverage Δ
driver/registry.go 44.82% <ø> (ø)
selfservice/flow/flow.go 100.00% <ø> (ø)
selfservice/strategy/oidc/error.go 75.00% <ø> (ø)
session/handler.go 67.94% <ø> (ø)
session/manager.go 100.00% <ø> (ø)
session/manager_http.go 75.92% <ø> (ø)
selfservice/flow/registration/handler.go 79.37% <25.00%> (ø)
selfservice/hook/session_issuer.go 86.20% <33.33%> (ø)
selfservice/strategy/oidc/strategy_registration.go 65.08% <44.44%> (ø)
selfservice/flow/registration/error.go 70.76% <50.00%> (ø)
... and 14 more

... and 5 files with indirect coverage changes

@vinckr vinckr marked this pull request as ready for review April 26, 2023 20:45
@vinckr vinckr merged commit 6db70a8 into master Apr 27, 2023
36 checks passed
@vinckr vinckr deleted the update-quickstart-13 branch April 27, 2023 04:58
@vinckr vinckr mentioned this pull request Apr 27, 2023
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants