Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use the correct redirect_uri for linkedin social login #3269

Merged
merged 1 commit into from May 8, 2023

Conversation

kmherrmann
Copy link
Contributor

LinkedIn Social Login shows the oryapis.com URL as the redirect target in the UI to the user, even when a custom domain is configured.
This works correctly on other social login providers. This PR points the flow to the right domain.

Related issue(s)

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    security@ory.sh) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

Reported in Community Slack

@kmherrmann kmherrmann requested review from Benehiko and removed request for aeneasr and zepatrik May 8, 2023 13:30
@codecov
Copy link

codecov bot commented May 8, 2023

Codecov Report

Merging #3269 (27a654c) into master (2f844ec) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 27a654c differs from pull request most recent head ac7fb04. Consider uploading reports for the commit ac7fb04 to get more accurate results

@@           Coverage Diff           @@
##           master    #3269   +/-   ##
=======================================
  Coverage   78.14%   78.15%           
=======================================
  Files         324      324           
  Lines       20763    20762    -1     
=======================================
+ Hits        16226    16227    +1     
+ Misses       3331     3330    -1     
+ Partials     1206     1205    -1     
Impacted Files Coverage Δ
selfservice/strategy/oidc/provider_linkedin.go 64.47% <100.00%> (ø)

... and 2 files with indirect coverage changes

Copy link
Contributor

@Benehiko Benehiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Benehiko Benehiko merged commit 27ccecc into master May 8, 2023
32 checks passed
@Benehiko Benehiko deleted the linkedin_url_fix branch May 8, 2023 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants