Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support exporting of all credential types #3290

Merged
merged 2 commits into from May 24, 2023
Merged

Conversation

aeneasr
Copy link
Member

@aeneasr aeneasr commented May 24, 2023

@aeneasr aeneasr requested a review from zepatrik as a code owner May 24, 2023 09:41
@codecov
Copy link

codecov bot commented May 24, 2023

Codecov Report

Merging #3290 (331041b) into master (5535fcb) will decrease coverage by 0.73%.
The diff coverage is 86.66%.

❗ Current head 331041b differs from pull request most recent head b7382f3. Consider uploading reports for the commit b7382f3 to get more accurate results

@@            Coverage Diff             @@
##           master    #3290      +/-   ##
==========================================
- Coverage   78.43%   77.71%   -0.73%     
==========================================
  Files         326      325       -1     
  Lines       21269    20513     -756     
==========================================
- Hits        16683    15942     -741     
+ Misses       3368     3355      -13     
+ Partials     1218     1216       -2     
Impacted Files Coverage Δ
identity/identity.go 92.00% <81.81%> (+0.24%) ⬆️
identity/handler.go 86.20% <84.61%> (+0.14%) ⬆️
examples/go/identity/get/main.go 75.00% <100.00%> (ø)
identity/credentials.go 83.67% <100.00%> (+5.89%) ⬆️

... and 9 files with indirect coverage changes

@aeneasr aeneasr merged commit de6c857 into master May 24, 2023
31 checks passed
@aeneasr aeneasr deleted the export-password branch May 24, 2023 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant