fix: use RETURNING clause for batch create #3293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alnr
reviewed
May 26, 2023
aeneasr
force-pushed
the
improve-persister-batch
branch
from
f07edcd
to
d01ce4c
Compare
|
Added some comments, all tests pass now. Should be good to go! |
Codecov Report
@@ Coverage Diff @@
## master #3293 +/- ##
==========================================
- Coverage 77.64% 77.57% -0.07%
==========================================
Files 325 325
Lines 20511 20570 +59
==========================================
+ Hits 15925 15958 +33
- Misses 3367 3386 +19
- Partials 1219 1226 +7
|
alnr
requested changes
May 30, 2023
persistence/sql/batch/create.go
Outdated
| @@ -38,7 +42,7 @@ type ( | |||
| } | |||
| ) | |||
|
|
|||
| func buildInsertQueryArgs[T any](ctx context.Context, quoter quoter, models []*T) insertQueryArgs { | |||
| func buildInsertQueryArgs[T any](ctx context.Context, dialect string, mapper *reflectx.Mapper, quoter quoter, models []*T) (insertQueryArgs, error) { | |||
There was a problem hiding this comment.
buildInsertQueryArgs never returns an error I think.
There was a problem hiding this comment.
true, probably an artifact form playing around with reflection. Will fix
alnr
approved these changes
May 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
batch.Createregressed on gobuffalo/pop improvements that useRETURNINGclauses andgen_random_uuid(). This patch addresses thatChecklist
introduces a new feature.
contributing code guidelines.
vulnerability. If this pull request addresses a security vulnerability, I
confirm that I got the approval (please contact
security@ory.sh) from the maintainers to push
the changes.
works.