Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reintroduce ExpandAll #3369

Merged
merged 1 commit into from Jul 6, 2023
Merged

fix: reintroduce ExpandAll #3369

merged 1 commit into from Jul 6, 2023

Conversation

aeneasr
Copy link
Member

@aeneasr aeneasr commented Jul 6, 2023

Related issue(s)

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    security@ory.sh) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

@aeneasr aeneasr requested a review from zepatrik as a code owner July 6, 2023 10:19
@aeneasr aeneasr changed the title fix: don't override existing fields in hydrator fix: reintroduce ExpandAll Jul 6, 2023
@codecov
Copy link

codecov bot commented Jul 6, 2023

Codecov Report

Merging #3369 (91ff9fb) into master (b75313e) will decrease coverage by 0.11%.
The diff coverage is 100.00%.

❗ Current head 91ff9fb differs from pull request most recent head 33ac6ae. Consider uploading reports for the commit 33ac6ae to get more accurate results

@@            Coverage Diff             @@
##           master    #3369      +/-   ##
==========================================
- Coverage   78.00%   77.90%   -0.11%     
==========================================
  Files         327      327              
  Lines       21282    21284       +2     
==========================================
- Hits        16602    16581      -21     
- Misses       3447     3466      +19     
- Partials     1233     1237       +4     
Impacted Files Coverage Δ
session/manager_http.go 78.64% <100.00%> (+0.22%) ⬆️

... and 2 files with indirect coverage changes

@aeneasr aeneasr merged commit 8f9bff5 into master Jul 6, 2023
31 checks passed
@aeneasr aeneasr deleted the max-aal-in-sess branch July 6, 2023 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant