Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: resolve flaky e2e tests #3935

Merged
merged 7 commits into from
May 29, 2024

Conversation

jonas-jonas
Copy link
Member

Related issue(s)

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    security@ory.sh) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

@jonas-jonas jonas-jonas self-assigned this May 24, 2024
@jonas-jonas jonas-jonas changed the title chore: reduce wait test: resolve flaky e2e tests May 24, 2024
Copy link

codecov bot commented May 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.06%. Comparing base (de8e59c) to head (fbb7d6d).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3935   +/-   ##
=======================================
  Coverage   78.05%   78.06%           
=======================================
  Files         362      362           
  Lines       25342    25342           
=======================================
+ Hits        19781    19783    +2     
- Misses       4043     4044    +1     
+ Partials     1518     1515    -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jonas-jonas jonas-jonas marked this pull request as ready for review May 27, 2024 05:44
Copy link
Contributor

@hperl hperl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@jonas-jonas jonas-jonas merged commit a14927d into master May 29, 2024
30 checks passed
@jonas-jonas jonas-jonas deleted the jonas-jonas/deflakeE2eAttempt14837823 branch May 29, 2024 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants