Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: active field should not be required #401

Merged
merged 1 commit into from
May 11, 2020

Conversation

AntiSC2
Copy link
Contributor

@AntiSC2 AntiSC2 commented May 9, 2020

Related issue

Closes ory/sdk#14

Proposed changes

I have marked the field active as not required because it is omitted if it not set. This causes problems when using the Python SDK.

Checklist

  • I have read the contributing guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security. vulnerability, I
    confirm that I got green light (please contact
    security@ory.sh) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further comments

Signed-off-by: Jakob Sinclair sinclair.jakob@mailbox.org

Closes ory/sdk#14

Signed-off-by: Jakob Sinclair <sinclair.jakob@mailbox.org>
@aeneasr
Copy link
Member

aeneasr commented May 11, 2020

Thank you!

@aeneasr aeneasr merged commit aed2a5c into ory:master May 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Active field should not be required for Kratos registration
2 participants