Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fallback to default return url if logout after url is not defined #594

Merged
merged 2 commits into from Jul 22, 2020

Conversation

zepatrik
Copy link
Member

Related issue

When selfservice.flows.logout.after.default_browser_return_url was not set a logout resulted in a fatal crash.

Proposed changes

The fallback now is selfservice.default_browser_return_url

Checklist

  • I have read the contributing guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security. vulnerability, I
    confirm that I got green light (please contact
    security@ory.sh) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further comments

@aeneasr aeneasr merged commit 7edd367 into master Jul 22, 2020
@aeneasr aeneasr deleted the require-after-logout-url branch July 22, 2020 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants