Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: render version schema on release #644

Merged
merged 2 commits into from Aug 10, 2020

Conversation

zepatrik
Copy link
Member

@zepatrik zepatrik commented Aug 7, 2020

Related issue

Proposed changes

Checklist

  • I have read the contributing guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security. vulnerability, I
    confirm that I got green light (please contact
    security@ory.sh) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further comments

@aeneasr
Copy link
Member

aeneasr commented Aug 9, 2020

Please update .goreleaser as well as this bumps the goreleaser version which is incompatible with the config file currently available :)

@aeneasr
Copy link
Member

aeneasr commented Aug 10, 2020

Any idea why e2e tests keep failing?

@zepatrik
Copy link
Member Author

Nope, I was wondering already as well....

@aeneasr
Copy link
Member

aeneasr commented Aug 10, 2020

Looks like they fail in other PRs as well but pass on master: https://app.circleci.com/pipelines/github/ory/kratos?branch=master

Maybe rebase?

@zepatrik
Copy link
Member Author

This branch is already based on the current master according to git-town sync

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants