Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add ory-prettier-styles to main repo #744

Merged
merged 3 commits into from Oct 6, 2020
Merged

fix: Add ory-prettier-styles to main repo #744

merged 3 commits into from Oct 6, 2020

Conversation

kevgo
Copy link
Contributor

@kevgo kevgo commented Oct 6, 2020

Proposed changes

Add ory-prettier-styles to main repo so that npm run format works there.

Checklist

  • I have read the contributing guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security. vulnerability, I
    confirm that I got green light (please contact
    security@ory.sh) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

package.json Outdated Show resolved Hide resolved
@zepatrik
Copy link
Member

zepatrik commented Oct 6, 2020

Maybe also add a npm run format:check directive and use the GH action from https://github.com/ory/prettier-styles ?

kevgo and others added 2 commits October 6, 2020 09:35
Co-authored-by: Patrik <zepatrik@users.noreply.github.com>
@kevgo
Copy link
Contributor Author

kevgo commented Oct 6, 2020

@zepatrik good idea to add the format:check task! I also like the idea of automating this further, for example via a GitHub action. Let's do that as a separate pull request.

@kevgo
Copy link
Contributor Author

kevgo commented Oct 6, 2020

All comments addressed, please take another look!

@zepatrik zepatrik merged commit aeaddbc into ory:master Oct 6, 2020
@kevgo kevgo deleted the kg-fix-ory-prettier-styles branch October 6, 2020 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants